Repository navigation
Add safety warnings to stackalloc examples - #56358
Open
GrabYourPitchforks wants to merge 2 commits into
Open
GrabYourPitchforks wants to merge 2 commits into
GrabYourPitchforks wants to merge 2 commits into
Conversation
GrabYourPitchforks
requested review from
a team and
BillWagner
as code owners
October 11, 2026 22:24
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The guidance incorrectly implies that the examples cap user input rather than only stack allocation size.
1 open finding
What changed in this PR
Adds safeguards that prevent negative lengths from reaching stackalloc and documents the process-termination risk.
Changes:
- Adds nonnegative checks to two allocation examples.
- Adds safety guidance for user-derived lengths.
| File | Description |
|---|---|
stackalloc.md |
Documents negative-length risks. |
StackallocOperator.cs |
Guards stack allocations against negative lengths. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The prose and examples at https://learn.microsoft.com/dotnet/csharp/language-reference/operators/stackalloc don't sufficiently convey the hazard of allowing negative values to flow to the
stackallocoperator.This PR updates the examples to include the necessary safety check and updates the text to explain the hazard of process termination.
Internal previews
Build report