Skip to content

gha/build: Use OIDC for Docker Hub login #7131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vvoland merged 2 commits into from
Jul 28, 2026
+8 −4
Merged

gha/build: Use OIDC for Docker Hub login #7131

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ff2ff6
gha/build: Use OIDC for Docker Hub login
vvoland Jul 28, 2026
52b1160
gha: bump docker/login-action from 4.4.0 to 4.5.0
vvoland Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,14 +100,18 @@ jobs:
bin-image:
runs-on: ubuntu-24.04
if: ${{ github.event_name != 'pull_request' && github.repository == 'docker/cli' }}
permissions:
contents: read
id-token: write
steps:
-
name: Login to DockerHub
name: Login to Docker Hub
if: github.event_name != 'pull_request'
uses: docker/login-action@af1e73f918a031802d376d3c8bbc3fe56130a9b0 # v4.4.0
uses: docker/login-action@06fb636fac595d6fb4b28a5dfcb21a6f5091859c # v4.5.0
env:
DOCKERHUB_OIDC_CONNECTIONID: ${{ vars.DOCKERHUB_OIDC_CONNECTIONID }}

@docker-agent docker-agent Jul 28, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[medium] OIDC connection ID set via env: — verify docker/login-action v4.5.0 reads it from the environment

The new step passes DOCKERHUB_OIDC_CONNECTIONID as a step-level env: variable rather than as a with: input to the action. Whether this is correct depends on how docker/login-action v4.5.0 is implemented:

  • If the action reads the connection ID from process.env.DOCKERHUB_OIDC_CONNECTIONID (e.g. a dedicated env-var API), the current usage is correct.
  • If the action only reads it via core.getInput('oidc-connection-id') or a similar with: input, then the value will be ignored, and OIDC authentication will silently fall back or fail on push.

docker/login-action v4.5.0 appears to be a new release that introduced OIDC support; the expected API surface for the connection ID should be confirmed against its release notes / source. If the action expects a with: input (e.g. oidc-connection-id), the fix would be:

Suggested change
DOCKERHUB_OIDC_CONNECTIONID: ${{ vars.DOCKERHUB_OIDC_CONNECTIONID }}
env:
DOCKERHUB_OIDC_CONNECTIONID: ${{ vars.DOCKERHUB_OIDC_CONNECTIONID }}
with:
username: dockereng
oidc-connection-id: ${{ vars.DOCKERHUB_OIDC_CONNECTIONID }}
Confidence Score
🟠 weak 43/100

with:
username: ${{ secrets.DOCKERHUB_CLIBIN_USERNAME }}
password: ${{ secrets.DOCKERHUB_CLIBIN_TOKEN }}
username: dockereng
-
name: Set up QEMU
uses: docker/setup-qemu-action@96fe6ef7f33517b61c61be40b68a1882f3264fb8 # v4.2.0
Expand Down