Skip to content

task-observer: deep-review updates from 2026-08-14 - #82

Open
divad12 wants to merge 1 commit into
masterfrom
task-observer/deep-review-2026-08-14
Open

divad12 wants to merge 1 commit into
masterfrom
task-observer/deep-review-2026-08-14

Conversation

@divad12

@divad12 divad12 commented Aug 14, 2026

Copy link
Copy Markdown
Owner

Target

skill: .agents/skills/deep-review/SKILL.md

Observations addressed

  • Observation 17 (journology/log.md): Review and bug learning need clear global/local layers → changed: (1) Rule compliance audit step now instructs reading docs/ai/review.md as project-specific deltas on top of the skill's default contracts when it exists; (2) Learning Closeout now includes routing guidance — cross-project findings go to dotfiles/docs/ai/<topic>.md rather than a project-local docs/ai/ that silently diverges from other projects.

Generated by Claude Code

Two additions:
1. Rule compliance audit now reads project docs/ai/review.md as project-specific
   deltas on top of the skill's default contracts (not a replacement).
2. Learning Closeout routing guidance: cross-project learnings belong in
   dotfiles/docs/ai/, not a project-local docs/ai/ that silently diverges.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MbsaUuqfh83jqTWAWDKHDx

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1307015e27

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".


**Routing:** when a finding is cross-project (the same failure mode or missing
guardrail would apply across codebases, not just this one), route the learning
to `dotfiles/docs/ai/<topic>.md` rather than the project's own `docs/ai/`.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Route global learnings through the dotfiles repository

When /deep-review runs from another project, dotfiles/docs/ai/<topic>.md is interpreted as a nonexistent child path, and it also conflicts with the preceding /learn workflow, which captures into the current repository's docs/learnings/ store. As a result, a cross-project finding may remain local or bypass capture, deduplication, and promotion entirely. Invoke learn --repo <dotfiles-checkout> capture for global evidence and let the learning workflow promote it to the canonical global docs/ai document.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants