perf(embedders): avoid a redundant copy in save_log_message - #11227
Merged
Conversation
`save_log_message` copied the whole `[src, src + size)` heap range into an owned `Vec` before appending it to the canister log. The log then truncates each record to its byte capacity, so all bytes beyond that capacity were copied only to be dropped right away. Copy just the bytes that are actually retained. The bounds check still covers the full range, so an out-of-bounds range is reported as such rather than being truncated, and the resulting log record is unchanged. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
✅ No security or compliance issues detected. Reviewed everything up to 4d2c878. Security Overview
Detected Code Changes
|
schneiderstefan
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
save_log_messagecopied the whole[src, src + size)heap range into an ownedVecbefore appending it to the canister log. The log then truncates each record to its byte capacity, so all bytes beyond that capacity were copied only to be dropped right away.Copy just the bytes that are actually retained. The bounds check still covers the full range, so an out-of-bounds range is reported as such rather than being truncated, and the resulting log record is unchanged.