feat: Carry over canister properties on rename_canister - #11212
Draft
mraszyk wants to merge 1 commit into
Draft
Conversation
The migration canister now proxies the migrated canister's creation timestamp, log memory store record index, canister metrics and query stats into its `rename_canister` call, and the management canister sets them on the renamed canister so that the canister ID keeps reporting a continuous history after a migration. The `rename_canister` endpoint additionally clears the renamed canister's log records (they were produced under its old ID; only the record index carries over) and stamps `last_install_timestamp` with the current round time, just like restoring a snapshot does. The creation timestamp and the log record index are read from `canister_status`, which gains a field for each; the metrics come from the existing `canister_metrics` endpoint and the query stats from the `query_stats` that `canister_status` already serves. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The migration canister now proxies the migrated canister's creation timestamp, log memory store record index, canister metrics and query stats into its
rename_canistercall, and the management canister sets them on the renamed canister so that the canister ID keeps reporting a continuous history after a migration.The
rename_canisterendpoint additionally clears the renamed canister's log records (they were produced under its old ID; only the record index carries over) and stampslast_install_timestampwith the current round time, just like restoring a snapshot does.The creation timestamp and the log record index are read from
canister_status, which gains a field for each; the metrics come from the existingcanister_metricsendpoint and the query stats from thequery_statsthatcanister_statusalready serves.