Skip to content

chore: Cleanup Type 4.0 deployment path - #11207

Merged
Bownairo merged 1 commit into
masterfrom
eero/type-four-cleanup
Aug 21, 2026
Merged

chore: Cleanup Type 4.0 deployment path#11207
Bownairo merged 1 commit into
masterfrom
eero/type-four-cleanup

Conversation

@Bownairo

@Bownairo Bownairo commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

4.0 is and was not used anywhere.

Type 4.0 originally was used to experiment with overcommitting vCPUs, and this later swapped with and replaced type 4.1.

@Bownairo
Bownairo force-pushed the eero/type-four-cleanup branch from c1c026a to 7f4d0a5 Compare August 18, 2026 19:44
Base automatically changed from eero/type-four-two to master August 18, 2026 22:12
@Bownairo
Bownairo force-pushed the eero/type-four-cleanup branch from 7f4d0a5 to 02f2ccd Compare August 18, 2026 23:57
@Bownairo Bownairo changed the title Eero/type four cleanup chore: Cleanup Type 4.0 deployment path Aug 19, 2026
@github-actions github-actions Bot added the chore label Aug 19, 2026
@Bownairo
Bownairo marked this pull request as ready for review August 19, 2026 17:46
@Bownairo
Bownairo requested a review from a team as a code owner August 19, 2026 17:46
@github-actions github-actions Bot added the @node label Aug 19, 2026
@zeropath-ai

zeropath-ai Bot commented Aug 19, 2026

Copy link
Copy Markdown

No security or compliance issues detected. Reviewed everything up to 02f2ccd.

Security Overview
Detected Code Changes
Change Type Relevant files
Bug Fix ► ic-os/components/hostos/guestos/start-guestos.sh
    Remove a conditional case for type4.0 in node_reward_type handling
Bug Fix ► ic-os/components/setupos/install-hostos.sh
    Remove a case entry for type4.0 in resize_partition function
Bug Fix ► rs/ic_os/os_tools/guest_vm_runner/src/guest_vm_config.rs
    Remove type4.0 handling in resource split for type 4 and adjust topology condition

@blind-oracle

Copy link
Copy Markdown
Contributor

4.0 isn't/wasn't used anywhere?

@Bownairo

Copy link
Copy Markdown
Contributor Author

4.0 isn't/wasn't used anywhere?

I just added a little blurb to the description. Maybe @r-birkner can confirm for sure that nobody is using this?

@r-birkner

Copy link
Copy Markdown
Contributor

Yes, type4.0 was never used. We only use type4 and then type4.1 to type4.5

@Bownairo
Bownairo added this pull request to the merge queue Aug 21, 2026
Merged via the queue into master with commit a08ba32 Aug 21, 2026
44 of 45 checks passed
@Bownairo
Bownairo deleted the eero/type-four-cleanup branch August 21, 2026 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants