Repository navigation
ci: stop S3 connection resets from failing integration runs - #525
Merged
Merged
Conversation
… fails CI LocalHttpCache#downloadIfMissing had no timeout and no retry, treated only an HTTP 5xx as noise, and kept nothing: 5 of the last 6 failed CI runs were 'Socket Connection reset' from S3 in s3_fullScan_decimalColumnMatchesJni and rust_vs_javaReader_statsMatch, always on an Ubuntu runner. Connection-level failures (reset, timeout, TLS, EOF) and 5xx are now retried three times with a growing pause and then skip the test; a 4xx still fails. The body goes to a temp file moved into the cache atomically, so each fixture is fetched once per run and a cut-off download never leaves a truncated file. LocalHttpCacheTest scripts the connection, so it needs no network. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Sko6B2519bE1TkpPx7WKxf
The fixture snapshot is pinned (RustFixtures.VERSION), so its hash keys the cache and a version bump starts a fresh one; with a hit the integration tests make no S3 requests. Windows skips integration. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Sko6B2519bE1TkpPx7WKxf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
5 of the last 6 failed CI runs were the same thing: `Socket Connection reset` fetching a fixture from S3 in `s3_fullScan_decimalColumnMatchesJni` (4 runs) and `rust_vs_javaReader_statsMatch` (2 runs), always on an Ubuntu runner (the sixth died in the Windows checkout cleanup, before any test). Root cause: `LocalHttpCache#downloadIfMissing` had no timeout and no retry, skipped only on an HTTP 5xx (a reset surfaced as an `IOException` and failed the test), and kept nothing, so every test class downloaded every fixture again.
Two commits:
Not touched: the edition-declaration fixtures, which track upstream `main` and must not be cached across runs.
🤖 Generated with Claude Code