Add features by Andrii Pravorskyi - #726
Conversation
| maintainer: Andrii Pravorskyi | ||
| contact: https://gitlab.com/pravorskyi/devcontainer-features/-/issues | ||
| repository: https://gitlab.com/pravorskyi/devcontainer-features | ||
| ociReference: registry.gitlab.com/pravorskyi/devcontainer-features |
There was a problem hiding this comment.
Hi pravorskyi
The ociReference appears to be invalid and returning 404. Would you kindly check.
There was a problem hiding this comment.
Thanks for checking! It seems to me that reference is valid.
The 404 is a GitLab registry strict policy, it returns 404 for manifest requests that don't include the OCI Accept header (ghcr.io tolerates this, GitLab doesn't).
Spec-compliant clients pull it fine anonymously, e.g.:
oras pull registry.gitlab.com/pravorskyi/devcontainer-features:latest
# Downloaded c620bb2546ea devcontainer-collection.jsonCould you check again, please?
There was a problem hiding this comment.
The devcontainer CLI sends the header GitLab requires. In the CLI's OCI client getManifest defaults to Accept: application/vnd.oci.image.manifest.v1+json.
https://github.com/devcontainers/cli/blob/main/src/spec-configuration/containerCollectionsOCI.ts#L315
https://github.com/devcontainers/cli/blob/main/src/spec-configuration/containerCollectionsOCI.ts#L522
What type of PR is this?
Related Issues
Description
Adds my dev container feature collection to the community index.
Collection checklist
If your PR contributes a new collection, please utilize this checklist:
ghcr.io/<owner>/<repo>— one entry per repository, not one per Feature; do not includehttp://orhttps://)