Skip to content

fix(webapp): null-safe getTime() calls in replication service for createdAt/updatedAt #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deepshekhardas wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −5
Open

fix(webapp): null-safe getTime() calls in replication service for createdAt/updatedAt #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions apps/webapp/app/services/runsReplicationService.server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1080,8 +1080,8 @@ export class RunsReplicationService {
organizationId, // organization_id
run.projectId, // project_id
run.id, // run_id
run.updatedAt.getTime(), // updated_at
run.createdAt.getTime(), // created_at
run.updatedAt?.getTime() ?? Date.now(), // updated_at
run.createdAt?.getTime() ?? Date.now(), // created_at
run.status, // status
environmentType, // environment_type
run.friendlyId, // friendly_id
Expand Down Expand Up @@ -1142,7 +1142,7 @@ export class RunsReplicationService {
// Return array matching PAYLOAD_COLUMNS order
return [
run.id, // run_id
run.createdAt.getTime(), // created_at
run.createdAt?.getTime() ?? Date.now(), // created_at
payload, // payload
];
}
Expand Down
4 changes: 2 additions & 2 deletions apps/webapp/app/services/sessionsReplicationService.server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -800,8 +800,8 @@ function toSessionInsertArray(
session.closedAt ? session.closedAt.getTime() : null,
session.closedReason ?? "",
session.expiresAt ? session.expiresAt.getTime() : null,
session.createdAt.getTime(),
session.updatedAt.getTime(),
session.createdAt?.getTime() ?? Date.now(),
session.updatedAt?.getTime() ?? Date.now(),
version.toString(),
isDeleted ? 1 : 0,
];
Expand Down