Appsmith UI updates for bare entity IDs - #124
Draft
Oluwajuwon-O wants to merge 9 commits into
Draft
Conversation
Align DOT App V2 test forms with bare entity references and the generic possible_duplicate_forms keys (date_column, group_column, id_column, period).
Same CI pylint threshold issue as datakind#122; this stacked branch still carried the pre-fix test module and failed lint at 6.79 (< 7.0).
Integration CI failed because the expected UUID was computed from alphabetical JSON key order, while the insert trigger's jsonb cast produces a different deterministic test_id.
Postgres jsonb returns keys in a deterministic order that differs from the hand-edited fixture string; align the expected summary row.
…e/appsmith_ui_updates Bring forward parent CI fixes: pylint disable, fixture test_id, and jsonb test_parameters key order.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Depends on domain_neutral PR #123
Prefixed entity IDs broke Appsmith column lookup
Test configuration forms historically saved and manipulated
ref('dot_model__...')/dot_model__...entity references. Appsmith’sJSFunctions.getEntityColumnsrelied on fragile.replace()stripping to recover bare IDs, which broke dropdown column population when formats varied.The UI still bound
possible_duplicate_formsinputs totable_specific_*keys. After the macro/seed rename, the configuration forms need to capture the generic keys instead.Resolution
Update
docker/appsmith/DOT App V2.jsonso that:ref('dot_model__...')).dot_model__/ref(...)string-stripping in Appsmith JS is removed; column lookup uses bare IDs directly.possible_duplicate_formsbindings use:date_columngroup_columnid_columnperiodThe export is also pretty-printed, which makes the diff large (
~+38klines). The behavioral changes above are the review focus; formatting alone is not intended to change runtime behavior.In the Technical Documentation, this is addressed in Section 8 (building on bare-entity storage in Section 6 and domain-neutral duplicate params in Section 7).
Depends on
prepare_test_parameters)possible_duplicate_formsparameters)This branch is stacked on those PRs. After they merge, use Update branch so the GitHub diff shrinks to the Appsmith-only changes.
Scope note
Backend helpers, dbt macro rename, SQL seeds, and self-test fixtures land in #122 / #123. This PR is the Appsmith UI binding for those contracts.
Asana Task
Deployment Readiness*
Testing
Describe or check:
Deployment Notes
Describe or check:
Rollback Plan
Describe or check:
git revert)Reviewer Guidance / Questions*
Screenshots / Testing Evidence*
SOC 2 Change Management Checklist
./vendor/bin/pest)Provide justification if you are submitting a PR with any boxes checked other than the first.
Reminder for Reviewers: By approving this PR you are confirming that you have reviewed the code for correctness, security, and compliance with our engineering and SOC 2 standards. Do not approve PRs where SOC 2 checklist items are checked without documented justification.
*Optional