fix: harden Asana link-check workflow against false rejections and API timeouts - #10
Merged
rachelauryn merged 2 commits intoJul 28, 2026
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
rachelauryn
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two independent issues in the `link-asana-task.yml` reusable workflow, both surfaced while debugging why datakind/edvise-api#282's required `asana` check kept failing:
1. The URL regex rejects a valid, common Asana link shape
The pattern only accepted `app.asana.com/1//project//task/` for current-UI links, but Asana also produces `app.asana.com/1//task/` (no `project//` segment) when a task link is copied from a project-less context — My Tasks, Inbox, search results, etc. That's a completely valid, resolvable Asana permalink, but it silently failed the "must include an Asana task URL" check, forcing PR authors to either dig through a confusing regex or hand-craft a different URL shape.
2. A flaky/slow Asana API call can block merges
The second step (`Asana/create-app-attachment-github-action@v1.3`, which posts a "GitHub PR" attachment widget onto the task — a nicety, not the actual requirement) has no timeout and isn't allowed to fail independently. When Asana's API is slow, this step hangs and times out (`598 Unable to serve response within time limit`), failing the whole required `asana` check even though the PR body already satisfies the real requirement (step 1, the regex check).
Context
Both issues were hit back-to-back on datakind/edvise-api#282:
Test plan