[TypeScript] Fix descriptor utility packaging and quick start - #555
Merged
Merged
Conversation
teodordelibasic-db
force-pushed
the
typescript/issue-389-usage-fix
branch
from
August 6, 2026 08:50
a7a540a to
53f6921
Compare
teodordelibasic-db
force-pushed
the
typescript/issue-389-usage-fix
branch
from
August 6, 2026 09:23
53f6921 to
5742f13
Compare
Signed-off-by: teodordelibasic-db <teodor.delibasic@databricks.com>
teodordelibasic-db
force-pushed
the
typescript/issue-389-usage-fix
branch
from
August 6, 2026 09:34
5742f13 to
fc71797
Compare
elenagaljak-db
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Fixes #389 by making
loadDescriptorProto()usable directly from the installed npm package:utils/descriptor.jsandutils/descriptor.d.tsprotobufjsas a runtime dependency of the package.jssubpath for CommonJS and native Node.js ESM and maps NodeNext resolution to the published declaration fileflush()oncePreviously, the npm package shipped only the TypeScript descriptor source, so Node.js could not import the documented utility. The protobuf walkthrough also mixed package-consumer steps with scripts and files that only exist in the source repository.
How is this tested?
Added three unit tests in
typescript/test/unit.test.ts:DescriptorProtoair_quality.protodoes not match a similarly suffixed file such asnot_air_quality.proto