Repository navigation
Conversation
masonc08
force-pushed
the
mason-cao_data/masonc08/aigtwy-4877-cuj2-mps-mcp
branch
3 times, most recently
from
October 6, 2026 00:32
d887243 to
132fea4
Compare
masonc08
force-pushed
the
mason-cao_data/masonc08/aigtwy-4877-cuj2-mps-mcp
branch
from
October 6, 2026 00:58
132fea4 to
20baee9
Compare
masonc08
force-pushed
the
mason-cao_data/masonc08/aigtwy-4877-cuj2-mps-mcp
branch
6 times, most recently
from
October 6, 2026 01:43
2539627 to
31bb970
Compare
lilly-luo
force-pushed
the
test/cuj-smart-routing
branch
5 times, most recently
from
October 6, 2026 06:29
2bacf37 to
60f93ce
Compare
masonc08
force-pushed
the
mason-cao_data/masonc08/aigtwy-4877-cuj2-mps-mcp
branch
from
October 6, 2026 12:45
1ac1c0d to
320af2d
Compare
masonc08
marked this pull request as ready for review
October 6, 2026 12:47
masonc08
force-pushed
the
mason-cao_data/masonc08/aigtwy-4877-cuj2-mps-mcp
branch
from
October 6, 2026 12:50
320af2d to
1fa74e1
Compare
masonc08
enabled auto-merge
October 6, 2026 14:31
lilly-luo
reviewed
Oct 6, 2026
| WORKSPACE_URL = "https://dbc-0dcf95cf-e357.cloud.databricks.com" | ||
|
|
||
|
|
||
| def _agent_config(agent: str) -> dict: |
Collaborator
There was a problem hiding this comment.
nit _agent_config -> expected_agent_config
Collaborator
There was a problem hiding this comment.
also is there a dataclass preexisting for the agent config that u can use?
Collaborator
Author
There was a problem hiding this comment.
i can make the rename. i dont think theres any existing dataclass we can reuse for this though
masonc08
force-pushed
the
mason-cao_data/masonc08/aigtwy-4877-cuj2-mps-mcp
branch
from
October 6, 2026 17:47
133d9f3 to
f187532
Compare
UG reviewThe PR changes Codex MCP credential forwarding and workspace discovery URL construction, and adds two-agent workspace CUJs with teardown cleanup. Major
Automated advisory review of |
david-siqi-liu
approved these changes
Oct 6, 2026
david-siqi-liu
left a comment
Collaborator
There was a problem hiding this comment.
Approving. One P1 to follow up on, not blocking:
P1
- The MPS listing, MPS get, and Anthropic models calls now build URLs from
normalize_workspace_url(workspace), which only adds a scheme and strips a trailing/.ug configure --workspacestores the URL as typed, so a workspace pasted ashttps://<host>/?o=123turns the listing URL intohttps://<host>/?o=123/api/2.1/.... Before this change,https://{hostname}dropped the query. #1004 addsworkspace_origin(scheme plus netloc, keeps the recorder port), and #987 carries the same hunks verbatim. Using it here avoids three PRs editing these lines three different ways.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What did you change, and why?
Added the dedicated CUJ2 journey for a real published
CodingAgentConfig: Codex usesug_e2e.providers.openaiwithgpt-5-nano, Claude usesug_e2e.providers.anthropicwithclaude-haiku-4-5-20251001, and both invokesystem.ai.sandboxthrough the real agent TUIs. The runner and managed CI lane now execute the serialized workspace-backed CUJ with service-principal auth, preserve/restore any prior config, redact credentials, and install the pinned SDK through the authenticated internal Python proxy.Skill coverage is intentionally deferred because the workspace Skill backend currently has a storage-path failure. This CUJ contains no Skill configuration, download, invocation, or assertion path.
How do you know it works?
system.ai.sandboxand the negativesystem.ai.web_searchfixture.This PR was created with GitHub MCP.