Skip to content

Ensure thrift field IDs are within range#302

Merged
vikrantpuppala merged 3 commits into
databricks:mainfrom
vikrantpuppala:thrift-field-test
Jun 25, 2025
Merged

Ensure thrift field IDs are within range#302
vikrantpuppala merged 3 commits into
databricks:mainfrom
vikrantpuppala:thrift-field-test

Conversation

@vikrantpuppala

@vikrantpuppala vikrantpuppala commented Jun 17, 2025

Copy link
Copy Markdown
Collaborator

Ensure thrift field IDs are within range

Test fails when limit is lowered:

Violations found:
  - TCLIService_types.js: Field ID 1281 exceeds maximum allowed value of 1199
  - TCLIService_types.js: Field ID 1282 exceeds maximum allowed value of 1199
  - TCLIService_types.js: Field ID 1283 exceeds maximum allowed value of 1199
  - TCLIService_types.js: Field ID 1284 exceeds maximum allowed value of 1199
  - TCLIService_types.js: Field ID 1285 exceeds maximum allowed value of 1199
  - TCLIService_types.js: Field ID 1286 exceeds maximum allowed value of 1199
  - TCLIService_types.js: Field ID 1287 exceeds maximum allowed value of 1199
  - TCLIService_types.js: Field ID 1288 exceeds maximum allowed value of 1199
  - TCLIService_types.js: Field ID 1289 exceeds maximum allowed value of 1199
  - TCLIService_types.js: Field ID 1296 exceeds maximum allowed value of 1199
      at Context.<anonymous> (tests/unit/thrift-field-id-validation.test.ts:47:13)
      at processImmediate (node:internal/timers:478:21)

@vikrantpuppala
Ensure thrift field IDs are within range
e3f03ac 
Signed-off-by: Vikrant Puppala <vikrant.puppala@databricks.com>
@vikrantpuppala
Merge remote-tracking branch 'databricks/main' into thrift-field-test
59e518a
@vikrantpuppala
fmt
f5090b9 
Signed-off-by: Vikrant Puppala <vikrant.puppala@databricks.com>
@vikrantpuppala
vikrantpuppala merged commit d886a41 into databricks:main Jun 25, 2025
13 of 16 checks passed
@vikrantpuppala
vikrantpuppala deleted the thrift-field-test branch June 25, 2025 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gopalldb gopalldb gopalldb approved these changes
@superdupershant superdupershant Awaiting requested review from superdupershant
@yunbodeng-db yunbodeng-db Awaiting requested review from yunbodeng-db
@andrefurlan-db andrefurlan-db Awaiting requested review from andrefurlan-db
@rcypher-databricks rcypher-databricks Awaiting requested review from rcypher-databricks
@jackyhu-db jackyhu-db Awaiting requested review from jackyhu-db
@benc-db benc-db Awaiting requested review from benc-db
@jadewang-db jadewang-db Awaiting requested review from jadewang-db
@deeksha-db deeksha-db Awaiting requested review from deeksha-db
@samikshya-db samikshya-db Awaiting requested review from samikshya-db
@jprakash-db jprakash-db Awaiting requested review from jprakash-db
@madhav-db madhav-db Awaiting requested review from madhav-db
@jayantsing-db jayantsing-db Awaiting requested review from jayantsing-db
@shivam2680 shivam2680 Awaiting requested review from shivam2680

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vikrantpuppala @gopalldb