Job runs drop unit tests covered by acc - #6370
Open
radakam wants to merge 2 commits into
Open
Conversation
failed_run, on_bundle_deploy, wait, and interrupted_run already assert the user-visible wait and trigger behavior. Add destroy_unfinished_run so cancel-before-delete is covered the same way.
radakam
marked this pull request as ready for review
August 24, 2026 16:43
Contributor
Approval status: pending
|
Collaborator
Integration test reportCommit: 3285057
6 interesting tests: 4 SKIP, 1 RECOVERED, 1 flaky
Top 8 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Drop
job_rununit tests that duplicate existing acceptance coverage, and adddestroy_unfinished_runso cancel-before-delete is asserted through the same path a user destroy takes.Kept the wait/GetRun stubs that acceptance cannot reach without faking the Jobs API.
Why
Split from review on #6309: if a unit test is already covered by acc, keep the acc test.
Tests
acceptance/bundle/resources/job_runs/destroy_unfinished_run(faulted wait, then destroy cancel + delete order)