direct: leave state closed when Open fails - #6330
Merged
Merged
Conversation
Open assigns db.Path before every fallible step, so a failed open left the receiver half-initialized: the next Open on the same value panicked with "state already opened" instead of reporting the real error. Move the body into unlockedOpen and reset the receiver when it fails. Finalize now shares the same reset helper. Co-authored-by: Isaac
Collaborator
Integration test reportCommit: e66c0b2
13 interesting tests: 8 flaky, 4 SKIP, 1 RECOVERED
Top 6 slowest tests (at least 2 minutes):
|
andrewnester
approved these changes
Aug 20, 2026
shreyas-goenka
added a commit
that referenced
this pull request
Aug 24, 2026
Merging #6330 left this branch textually clean and broken: it split Open's body into unlockedOpen, and the DMS block went with the body while the parameter stayed on Open, so dmsSource was undefined. Thread it through, and pass nil from the test #6330 added. Also records the deployment-history variant for the three destroy tests that arrived with the same merge. Co-authored-by: Isaac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open assigns db.Path before every fallible step, so a failed open left the receiver half-initialized: the next Open on the same value panicked with "state already opened" instead of reporting the real error.
Move the body into unlockedOpen and reset the receiver when it fails. Finalize reuses the same reset helper.