Bump Terraform provider to v1.118.0#5637
Merged
Merged
Conversation
Collaborator
Integration test reportCommit: d852718
21 interesting tests: 14 SKIP, 7 KNOWN
Top 20 slowest tests (at least 2 minutes):
|
The SDK bump to v0.147.0 (#5636) added top-level ID fields (project_id, branch_id, endpoint_id, database_id, role_id, catalog_id) to the postgres resource types, which the real Lakebase GET APIs now return. This broke every postgres acceptance test on cloud with golden-file mismatches. Regenerated the affected goldens against cloud, and taught the testserver to emit the same top-level IDs on create so local runs match cloud. Synced tables are unaffected. Co-authored-by: Isaac
Regenerate bundle/internal/tf/schema and terraform_dabs_map/generated.go from the v1.118.0 Databricks Terraform provider, and refresh the user-agent / provider-version acceptance goldens. Co-authored-by: Isaac
The v1.118 provider serializes postgres identity fields (branch_id, project_id, database_id, role_id, ...) into create request bodies; the direct engine sends them only as query params. Add a --del-body option to print_requests.py and extend the recreate jq helpers' del() so recorded request goldens drop these fields and stay identical across engines, instead of needing per-engine goldens. Co-authored-by: Isaac
pietern
force-pushed
the
bump-tf-provider
branch
from
bf144ff to
7a9a240
Compare
Drop the local jq-based print_requests() helpers in the recreate tests and call print_requests.py directly with --del-body (the helpers existed only to scrub divergent body fields, which --del-body now handles). branches/recreate's request goldens collapse from per-engine to shared since the scrub removes the only divergence. Co-authored-by: Isaac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Bump the pinned Databricks Terraform provider from v1.117.0 to v1.118.0, regenerate
bundle/internal/tf/schemaandterraform_dabs_map, and refresh the affected acceptance goldens.Note: v1.118 serializes resource
_idfields (branch_id,project_id, …) into request bodies, whereas the direct engine sends them only as query params. To keep goldens engine-agnostic,print_requests.pygained a--del-bodyflag to scrub those fields, and the postgres recreate tests are consolidated ontoprint_requests.py(dropping their bespoke jq helpers) in the process.Tests
Acceptance regenerated; the postgres suite passes on both deployment engines.
This PR was written by Isaac.