Reproduce stale-published-content dashboard bug as acceptance test#5597
Open
denik wants to merge 13 commits into
Open
Reproduce stale-published-content dashboard bug as acceptance test#5597denik wants to merge 13 commits into
denik wants to merge 13 commits into
Conversation
Co-authored-by: Denis Bilenko <denis.bilenko@databricks.com>
… calls Co-authored-by: Denis Bilenko <denis.bilenko@databricks.com>
Previously the fake workspace only bumped the etag when SerializedDashboard changed. Cloud bumps it on every write. Update the test server and regenerate the stale-content acceptance test output accordingly. Co-authored-by: Isaac
SaveState is only called on success; the failing second deploy leaves state with the pre-PATCH etag. The third deploy detects the etag mismatch and errors with "modified remotely" instead of silently skipping publish. Wrap the third deploy in errcode so the subsequent get/get-published calls run and show the draft renamed while the published version is still stale. Co-authored-by: Isaac
Contributor
Approval status: pending
|
…e-content Co-authored-by: Isaac
Co-authored-by: Isaac
Co-authored-by: Isaac
Co-authored-by: Isaac
Co-authored-by: Isaac
Co-authored-by: Isaac
Collaborator
Integration test reportCommit: 39aa4fc
22 interesting tests: 15 SKIP, 7 RECOVERED
Top 30 slowest tests (at least 2 minutes):
|
…r DoUpdate DoUpdate may mutate newState in place (e.g. etag) and server-generated fields may change on every write. Update the test to compare DoUpdate's return value against a fresh DoRead, and update remappedState to the post-update value so the subsequent field checks stay consistent. Co-authored-by: Isaac
Replace add_repl.py calls with direct echo in tests that run with MSYS_NO_PATHCONV=1. When this env var is set, MSYS does not convert Unix-style paths to Windows format before passing them to Python.exe, causing the shebang invocation to fail with the wrong path. Direct echo to ACC_REPLS avoids Python entirely and works on all platforms. Co-authored-by: Denis Bilenko <denis.bilenko@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an acceptance test for the bug where a dashboard rename succeeds (PATCH) but the subsequent publish fails, leaving the user unable to recover by simply re-running deploy.
What the test shows:
SaveStateis only called on success, so state retains the pre-PATCH etag.state.etag ≠ remote.etagand errors with "dashboard has been modified remotely" — no API writes are attempted, so the stale published version ("my dashboard") is never updated.Also includes:
testserver: bump dashboard etag on every PATCH (previously only bumped whenSerializedDashboardchanged), matching actual cloud behaviorETAGregex replacements intest.tomlwith per-testadd_repl.pycalls so etag value changes are visible in diffs