Partly revert mask expanding - #21607
Closed
jenshannoschwalm wants to merge 2 commits into
Closed
Conversation
Collaborator
Author
|
marked as draft as i would love to see your comment @masterpiga |
jenshannoschwalm
marked this pull request as draft
July 24, 2026 08:54
Member
|
Not working for me, when you move the canvas the mask is not moved, so after creating a path mask around the disk and moving the canvas (without zooming - fit mode) I get: 
|
Collaborator
Author
|
Closing this PR - happily leaving this to @masterpiga :-) |
Collaborator
|
Thanks for attempting a fix, Hanno. I am looking into it, I hope to have a fix in one or two days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@masterpiga @TurboGit
We have several issues with #21382 notably #21606 #21594
I checked this and from my finding i would say
Honestly i don't understand what's done and why it's done the way it's done in reverted file changes (confessing i didn't try hard and the comments confused me even more ...) so maybe i am missing something. At least after the "partial revert" everything looks&feels good on my side. And from that remaining simple code i wouldn't expect problems.