Repository navigation
ja: verify geometry, overview and calculus strings; say the angle name before 大きさ; read Log as 対数のしゅち - #969
Open
yasumorishima wants to merge 1 commit into
Open
yasumorishima wants to merge 1 commit into
yasumorishima wants to merge 1 commit into
Conversation
…e before 大きさ; read Log as 対数のしゅち Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PxieeR5Zo8C2XvcgnBBCDc
Linux library size: 0.59 MiB (0.00%)
Built with default features, Rust 1.96.0, and Ubuntu 24.04. Workflow run. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This marks the Japanese strings in SharedRules/geometry.yaml, overview.yaml and SharedRules/calculus.yaml as verified after checking each one against English, and fixes two readings. The measure of an angle was 角の大きさ A B C, which keeps the English word order; Japanese names the angle first, so it is now 角 A B C の大きさ, and a new rule in geometry.yaml says the angle-measure intent the same way, because a definitions.yaml entry cannot put words on both sides of the operand; when its operand already says 角, as in m∠ABC, it is not said twice. Log z, the principal value of the logarithm, was 主値ログ, and Open JTalk reads the kanji 主値 as シュネ; Japanese texts call Log z 対数の主値 (for example, Kyushu University's complex analysis lecture notes), so it is now 対数のしゅち, with 主値 written in kana. calculus.yaml is not included by the ClearSpeak or SimpleSpeak rules, but its words are the same as the definitions.yaml entries that the existing ja tests cover. New tests cover the angle, Log, and the overview root, fraction and long row. All language tests pass and audit-translations ja has 31 fewer untranslated strings and one extra rule, the new angle-measure rule, with rule differences unchanged.