Skip to content

fix(test): make experience notification test order-independent - #4121

Merged
rebelchris merged 1 commit into
mainfrom
fix/experience-notification-test-order
Aug 21, 2026
Merged

fix(test): make experience notification test order-independent#4121
rebelchris merged 1 commit into
mainfrom
fix/experience-notification-test-order

Conversation

@rebelchris

Copy link
Copy Markdown
Contributor

The experienceCompanyEnrichedNotification test selects 'the current work experience' via findOne on userId/type/endedAt: null with no ordering and no title filter. experienceCompanyEnrichment tests save user-1 work experiences titled 'Software Engineer' with no endedAt and no table cleanup, and suites in the same CircleCI container share the database — so whether the residue exists when this suite runs depends on the timing-based test split. Any PR that shifts suite timings (e.g. #4110, where this surfaced with a green-then-red flip on unrelated changes) can flip the result.

Adding the fixture title to the where clause makes the selection deterministic; duplicates of the same fixture row are harmless since every asserted field is identical.

🤖 Generated with Claude Code

The findOne selecting 'the current work experience' filtered only on
userId/type/endedAt with no ordering. Suites sharing a CI container leave
user-1 work experiences behind (experienceCompanyEnrichment saves
'Software Engineer' rows without endedAt or cleanup), so CircleCI's
timing-based test split decides whether the residue exists when this
suite runs — any PR that shifts suite timings can flip the result.
Filtering on the fixture title makes the selection deterministic.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@pulumi

pulumi Bot commented Aug 21, 2026

Copy link
Copy Markdown

🍹 The Update (preview) for dailydotdev/api/prod (at d63b247) was successful.

Resource Changes

    Name                                                       Type                           Operation
~   vpc-native-interest-scheduled-run-cron                     kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-expired-better-auth-sessions-cron         kubernetes:batch/v1:CronJob    update
~   vpc-native-calculate-top-readers-cron                      kubernetes:batch/v1:CronJob    update
~   vpc-native-update-trending-cron                            kubernetes:batch/v1:CronJob    update
~   vpc-native-rotate-weekly-quests-cron                       kubernetes:batch/v1:CronJob    update
+   vpc-native-api-db-migration-10d0f81a                       kubernetes:batch/v1:Job        create
~   vpc-native-clean-gifted-plus-cron                          kubernetes:batch/v1:CronJob    update
~   vpc-native-user-profile-analytics-history-clickhouse-cron  kubernetes:batch/v1:CronJob    update
~   vpc-native-user-world-clickhouse-cron                      kubernetes:batch/v1:CronJob    update
~   vpc-native-bg-deployment                                   kubernetes:apps/v1:Deployment  update
~   vpc-native-squad-posts-analytics-refresh-cron              kubernetes:batch/v1:CronJob    update
~   vpc-native-refresh-tool-stack-stats-cron                   kubernetes:batch/v1:CronJob    update
~   vpc-native-worker-job-deployment                           kubernetes:apps/v1:Deployment  update
~   vpc-native-post-analytics-history-day-clickhouse-cron      kubernetes:batch/v1:CronJob    update
~   vpc-native-update-current-streak-cron                      kubernetes:batch/v1:CronJob    update
~   vpc-native-post-analytics-clickhouse-cron                  kubernetes:batch/v1:CronJob    update
~   vpc-native-personalized-digest-deployment                  kubernetes:apps/v1:Deployment  update
~   vpc-native-user-posts-analytics-refresh-cron               kubernetes:batch/v1:CronJob    update
~   vpc-native-world-index-cron                                kubernetes:batch/v1:CronJob    update
~   vpc-native-temporal-deployment                             kubernetes:apps/v1:Deployment  update
~   vpc-native-rotate-daily-quests-cron                        kubernetes:batch/v1:CronJob    update
~   vpc-native-update-tag-materialized-views-cron              kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-channel-highlights-cron                   kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-zombie-users-cron                         kubernetes:batch/v1:CronJob    update
~   vpc-native-user-profile-updated-sync-cron                  kubernetes:batch/v1:CronJob    update
~   vpc-native-ws-deployment                                   kubernetes:apps/v1:Deployment  update
~   vpc-native-update-highlighted-views-cron                   kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-zombie-user-companies-cron                kubernetes:batch/v1:CronJob    update
~   vpc-native-validate-active-users-cron                      kubernetes:batch/v1:CronJob    update
~   vpc-native-channel-digests-cron                            kubernetes:batch/v1:CronJob    update
~   vpc-native-expire-super-agent-trial-cron                   kubernetes:batch/v1:CronJob    update
~   vpc-native-update-views-cron                               kubernetes:batch/v1:CronJob    update
~   vpc-native-sync-subscription-with-cio-cron                 kubernetes:batch/v1:CronJob    update
~   vpc-native-update-achievement-rarity-cron                  kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-old-notifications-cron                    kubernetes:batch/v1:CronJob    update
~   vpc-native-channel-highlights-cron                         kubernetes:batch/v1:CronJob    update
~   vpc-native-check-analytics-report-cron                     kubernetes:batch/v1:CronJob    update
-   vpc-native-api-clickhouse-migration-a7b207a7               kubernetes:batch/v1:Job        delete
~   vpc-native-materialize-monthly-best-post-archives-cron     kubernetes:batch/v1:CronJob    update
~   vpc-native-post-analytics-achievements-cron                kubernetes:batch/v1:CronJob    update
~   vpc-native-materialize-yearly-best-post-archives-cron      kubernetes:batch/v1:CronJob    update
... and 20 other changes

@rebelchris
rebelchris merged commit d337040 into main Aug 21, 2026
9 checks passed
@rebelchris
rebelchris deleted the fix/experience-notification-test-order branch August 21, 2026 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant