Skip to content

fix: use servicer type in runtime #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eric-carlsson wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −5
Open

fix: use servicer type in runtime #212

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions crossplane/function/runtime.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ def load_credentials(tls_certs_dir: str) -> grpc.ServerCredentials:


def serve(
function: grpcv1.FunctionRunnerService,
function: grpcv1.FunctionRunnerServiceServicer,
address: str,
*,
creds: grpc.ServerCredentials,
Expand Down Expand Up @@ -134,20 +134,20 @@ async def start():
loop.close()


class BetaFunctionRunner(grpcv1beta1.FunctionRunnerService):
class BetaFunctionRunner(grpcv1beta1.FunctionRunnerServiceServicer):
"""A BetaFunctionRunner handles beta gRPC RunFunctionRequests.

It handles requests by passing them to a wrapped v1.FunctionRunnerService.
It handles requests by passing them to a wrapped v1.FunctionRunnerServiceServicer.
Incoming v1beta1 requests are converted to v1 by round-tripping them through
serialization. Outgoing requests are converted from v1 to v1beta1 the same
way.
"""

def __init__(self, wrapped: grpcv1.FunctionRunnerService):
def __init__(self, wrapped: grpcv1.FunctionRunnerServiceServicer):
"""Create a new BetaFunctionRunner."""
self.wrapped = wrapped

async def RunFunction( # noqa: N802 # gRPC requires this name.
async def RunFunction( # noqa: N802 # gRPC requires this name. # pyright: ignore[reportIncompatibleMethodOverride]
self, req: fnv1beta1.RunFunctionRequest, context: grpc.aio.ServicerContext
) -> fnv1beta1.RunFunctionResponse:
"""Run the underlying function."""
Expand Down