Repository navigation
Fixed ordering purchasable queries by salePrice - #4448
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Variant::find()->orderBy('salePrice')didn't sort anything when there were no catalog pricing rules.PurchasableQuerydoesn't selectsalePrice(it's a read-only attribute on the element), soORDER BY "salePrice"didn't name a real column. SQLite treats that as a string literal and returns rows unsorted; MySQL and Postgres would error.QueriesPurchasablePricingnow rewritesprice,promotionalPriceandsalePriceorder clauses in itsbeforeQuerycallback, before cms resolves the query's order columns:catalogprices.price,catalogprices.promotionalPriceandcatalogprices.salePrice.purchasables_stores.basePrice,basePromotionalPrice, and the sameCASE WHENsale price expression thesalePrice()filter already uses (moved into a shared helper).The new tests give the most expensive variant a promotional price, so a sort that does nothing can't pass. The
salePricecases fail without this change. Closes COM-668.🤖 Generated with Claude Code