Skip to content

Allow for move only matcher#334

Merged
sgerbino merged 2 commits into
cppalliance:develop-2from
sgerbino:pr/move-only-matcher
Jun 23, 2026
Merged

Allow for move only matcher#334
sgerbino merged 2 commits into
cppalliance:develop-2from
sgerbino:pr/move-only-matcher

Conversation

@sgerbino

Copy link
Copy Markdown
Collaborator

Closes #332.

term-est and others added 2 commits June 23, 2026 21:41
The MatchCondition concept requires only callability, not copyability,
so read_until must accept move-only matchers. Add a matcher holding its
delimiter in a unique_ptr and exercise it through the await_suspend I/O
path, which previously copied the matcher and rejected such types.
@cppalliance-bot

Copy link
Copy Markdown

An automated preview of the documentation is available at https://334.capy.prtest3.cppalliance.org/index.html

If more commits are pushed to the pull request, the docs will rebuild at the same URL.

2026-06-23 20:48:05 UTC

@codecov

codecov Bot commented Jun 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.17%. Comparing base (9144290) to head (c030156).
⚠️ Report is 1 commits behind head on develop-2.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##           develop-2     #334      +/-   ##
=============================================
+ Coverage      98.07%   98.17%   +0.09%     
=============================================
  Files            164       82      -82     
  Lines           8774     4161    -4613     
=============================================
- Hits            8605     4085    -4520     
+ Misses           169       76      -93     
Flag Coverage Δ
linux 98.17% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 83 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9144290...c030156. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sgerbino sgerbino merged commit 51116a0 into cppalliance:develop-2 Jun 23, 2026
37 checks passed
@sgerbino sgerbino deleted the pr/move-only-matcher branch June 23, 2026 21:01
@cppalliance-bot

Copy link
Copy Markdown

GCOVR code coverage report https://334.capy.prtest3.cppalliance.org/gcovr/index.html
LCOV code coverage report https://334.capy.prtest3.cppalliance.org/genhtml/index.html
Coverage Diff Report https://334.capy.prtest3.cppalliance.org/diff-report/index.html

Build time: 2026-06-23 21:04:59 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants