fix: terse success output for integration/cloud connect - #15
Merged
Conversation
… raw object Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Eaq5cSYopxj9cj1mq78vt
|
Warning Polylane could not verify the production impact of this pull request. Checked both changed files — the CLI is an npm package, not a deployed worker, so no production resource runs this code. JSON output is unchanged; only human-readable terminal output moves to terse success lines. Polylane could not find the cloud resources this repository manages, so this review looked at the entire cloud account. Connect this repository to its resources and the next review will focus on exactly what this code deploys to. Polylane analysed |
…success # Conflicts: # src/commands/cloud/connect.ts # src/commands/integration/connect.ts
boristane
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by boris · Slack thread
Before
Connecting an integration or cloud account with credentials dumped the entire API response object to the terminal — every field, including token/cipher metadata:
After
Cloud accounts print the same one-liner already used by the browser-wait flows:
--output json(and piped output) still emits the raw response object unchanged.How
Both
integration connectandcloud connectget a smallprintConnectSuccesshelper: JSON mode delegates toformatOutputas before; the human path writes the same✓ … connectedline the existing browser-completion flows already print (stderr, matching in-file convention). Covers every synchronous connect path:Cloud connect failures (partial multi-account connects) are now printed as plain
Failed to connect <account>: <message>lines instead of pointing at a"failures"key in the dump. Browser-based flows (GitHub, Slack, Sentry, MCP OAuth, AWS, Vercel, Supabase, PlanetScale OAuth) already printed terse confirmations and are untouched.Note for reviewers: two parallel PRs touch the same CLI connect flows (back-navigation in prompts, and token-permission guidance before the paste prompt) — expect possible merge conflicts in these files.
🤖 Generated with Claude Code
https://claude.ai/code/session_013Eaq5cSYopxj9cj1mq78vt
Generated by Claude Code