fix: improve Brandfolder asset field preview in entry editor [AIS-447] - #11282
Open
Jared Jolton (jjolton-contentful) wants to merge 7 commits into
Open
fix: improve Brandfolder asset field preview in entry editor [AIS-447]#11282Jared Jolton (jjolton-contentful) wants to merge 7 commits into
Jared Jolton (jjolton-contentful) wants to merge 7 commits into
Conversation
Show filenames, metadata, and clickable asset links in the Brandfolder field editor by wiring getAdditionalData and polishing dam-app-base thumbnail cards (checkerboard background, always-visible labels). Upgrade Brandfolder to dam-app-base 4.x and React 19. Co-authored-by: Cursor <cursoragent@cursor.com>
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try the Wiz Code extension for VS Code, JetBrains, or Visual Studio. |
![wiz-inc-38d59fb8d7[bot]](https://avatars.githubusercontent.com/u/472182?s=60&v=4){kind=small}
Pre-bundle the workspace-linked @contentful/dam-app-base package in Vite so named CJS exports resolve during local development. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Jared Jolton (jjolton-contentful)
changed the title
Upgrade @contentful/app-scripts to 4.1.8 and pin adm-zip to 0.6.0 via npm overrides to address the transitive DoS vulnerability. Co-authored-by: Cursor <cursoragent@cursor.com>
Add .npmrc to pin @contentful packages to registry.npmjs.org. The prior lockfile was generated against GitHub Packages, which caused 401 errors in CI bootstrap when installing transitive @contentful dependencies. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Update GetAdditionalData JSDoc, add 4.0.6 CHANGELOG entry for the card redesign, and add SortableComponent RTL tests for filename links. Co-authored-by: Cursor <cursoragent@cursor.com>
Jared Jolton (jjolton-contentful)
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getAdditionalDatain the Brandfolder app so selected assets show filename, dimensions/size, and a clickable link to the CDN/original file@contentful/dam-app-baseasset cards with a checkerboard thumbnail background, always-visible filename labels, and optional external links viaAdditionalData.hrefdam-app-base4.x and React 19 so it can use the newer field editor APIsTest plan
npm run buildinpackages/dam-app-baseandapps/brandfoldernpm run test:ciinpackages/dam-app-baseMade with Cursor