Repository navigation
reject line endings in pointy-bracket link destinations - #637
Merged
Merged
Conversation
Member
|
good, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The spec says a pointy-bracket link destination cannot contain a line ending, even one that is preceded by a backslash, but manual_scan_link_url in src/inlines.c advances two bytes on any backslash without looking at the next byte, so a backslash right before a newline makes the scan jump over the line ending and keep going on the next line. That lets cmark accept e.g.
as a link whose destination spans two lines, while the reference parser (and the "destination cannot contain line endings" rule at spec.txt:7596) treats it as plain text. The fix only consumes the escape when the next byte exists and isn't a newline, otherwise the scan fails, which lines up with the newline check already sitting in the same loop. Reviewers may want to confirm the escaped-
>case ([a](<b\>c>)) still parses as a link, which it does. Added a regression case to test/regression.txt that fails before the change and passes after.