Add support for exporting some basic metrics - #131
Open
refi64 wants to merge 1 commit into
Open
Conversation
sjoerdsimons
reviewed
Aug 3, 2026
| K: Eq + std::hash::Hash, | ||
| { | ||
| fn update_running_count(&self, n: usize) { | ||
| metrics::gauge!(METRICS_GAUGE_JOBS_RUNNING).set(n as u32); |
Collaborator
There was a problem hiding this comment.
Should there be a gauge for this as i'ts derivable from finished - start ?
Collaborator
Author
There was a problem hiding this comment.
I figured since the origin story of this was debugging-related, having a value tied directly to the runlist vs start/end being a layer further up might be useful. I'm not particularly attached though and would be fine with removing it if preferred.
Only a few to start with, but they should be useful for helping to debug collabora/lava-gitlab-runner#129. Client crates can just set up the metrics exporter of their choice to be able to use this.
refi64
force-pushed
the
wip/refi64/metrics
branch
from
August 3, 2026 16:00
9de6cf7 to
2140e68
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only a few to start with, but they should be useful for helping to debug collabora/lava-gitlab-runner#129. Client crates can just set up the metrics exporter of their choice to be able to use this.