Conversation
Change-Id: I41f9bade8b8ace222cf694ce9f0024ebc50ba8cf Signed-off-by: Thomas Kosiewski <tk@coder.com>
Shorten the sandbox README's main reading path: tables for transports, workspace requirements, ensureCoderWorkspace settings, and lifecycle modes; transport rationale in collapsible blocks; Development trimmed to the package-specific e2e commands. Move the zero-install template authoring guide to packages/sandbox/docs/template-authoring.md, keeping a summary under the same README heading so anchors still resolve. Signed-off-by: Thomas Kosiewski <tk@coder.com>
…curity.md Change-Id: I7e13f8a135436171e10959f2a8e189e4b7c52fbb Signed-off-by: Thomas Kosiewski <tk@coder.com>
Change-Id: I0f1c1c369b1b1cae3cb3d5112e6f3fe4bc8050cb Signed-off-by: Thomas Kosiewski <tk@coder.com>
Change-Id: Ib15397d81356a03cb3552404db0d7d19cd769982 Signed-off-by: Thomas Kosiewski <tk@coder.com>
Rewrite packages/agent/README.md for skimming: result-first sections, tables for options/errors/return values, and internals in <details>. Move the transport-event reference to docs/observability.md and the structured_output tool pattern to docs/structured-output.md, keeping short summaries under the same headings. Replace the Workspaces & quota and Durable workflows sections with summaries that link to their new docs files (written separately). Signed-off-by: Thomas Kosiewski <tk@coder.com>
Extract the Workspaces & quota and Durable workflows README sections into standalone guides under packages/agent/docs/, restructured for skimming: tables for options and error types, edge cases and protocol internals moved into <details> blocks. Former ### headings are kept as ## with identical text so anchors resolve. Signed-off-by: Thomas Kosiewski <tk@coder.com>
Change-Id: I33368a8f75e4a0f5da1a315a00418d195d9e26c2 Signed-off-by: Thomas Kosiewski <tk@coder.com>
…tructured-output guide Change-Id: I9af034917593a3063392a959edb0ab2efa0523f1 Signed-off-by: Thomas Kosiewski <tk@coder.com>
|
@codex review |
|
@codex security review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 08611ee70b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Change-Id: I4e94061f65d31cc017ec19e2aabf2d9af49a542e Signed-off-by: Thomas Kosiewski <tk@coder.com>
|
@codex review |
|
@codex security review |
|
Codex Review: Something went wrong. Try again later by commenting “@codex review”. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
|
@codex security review |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
Rewrites the READMEs and project docs for readability: shorter prose, tables instead of paragraphs, and long how-to sections moved into per-package
docs/guides. The agent README goes from 1,862 to ~830 lines (rendered page −61%).What changed
README.mdpackages/agent/README.mdpackages/sandbox/README.mdpackages/provider/README.md<details>New guides (each old README heading keeps a short summary + link, so existing anchors still resolve):
packages/agent/docs/:durable-workflows.md,workspaces-and-quota.md,observability.md,structured-output.mdpackages/sandbox/docs/template-authoring.mdpackages/provider/docs/security.mddocsis added tofilesin the agent, sandbox, and providerpackage.json, so these links also resolve in installed packages.Content was relocated, not deleted: total words across all docs are roughly unchanged (24.7k → 24.5k); visible README prose dropped 30–48%.
Factual corrections
Verification tier: verified against source.
/api/v2/chats(Coder 2.37.0) with a 404 fallback to the experimental prefix (packages/agent/src/coder/client.ts).CoderAgent"may provision a workspace", contradicting "This SDK never provisions workspaces". Now: "bound to at most one workspace".Validation
2c1d888. They found one meaning change: a table applied the timeout-onlycutShortpin tostream_closedtoo. It is fixed in 08611ee, together with two stale rule links.examples/).pnpm checkpasses. A relative link + anchor checker over all tracked Markdown finds 0 broken links.Screenshots
Rendered via GitHub's markdown API.
Root README, before:
Root README, after:
Agent README, after (contents table):
Follow-up PR (stacked) fixes pre-existing inaccuracies found during the rewrite (
requestTimeoutMswording, BYOK qualifier, release-please-ai overstatement, a non-compiling snippet placeholder, links to paths not shipped in npm packages).Generated with
xum• Model:anthropic:claude-opus-5-5• Thinking:high