Repository navigation
cants exits 0 on FATAL and on a nonexistent input path, writing an empty-application analysis.json #181
Description
Activity
Refinement: the exit code is inconsistent, not uniformly zero — so some failure paths already set it and these two do not.
failure stderr exit nonexistent -ipath(silent) 0 structuredCloneFATAL infinalizeAnalysis(#180)[codeanalyzer-ts] FATAL TypeError0 Neo4j rejects a commit during --emit neo4j[codeanalyzer-ts] FATAL Neo4jError1 All three print
FATAL(except the first, which prints nothing at all), so the distinction is not "fatal vs recoverable" — it looks like the emit path propagates its failure to the process exit and the analysis path does not.That makes the fix narrower than I first suggested: the
FATALreporter itself should set a non-zero exit, rather than each call site remembering to. The nonexistent-path case is separate and needs its own guard, since it prints nothing and still writes a payload.- added a commit that references this issue
on Sep 7, 2026 Closed by #187 for the input-path half (nonexistent or non-directory
-i→ one-line usage error, exit 1, nothing written; an empty real directory still exits 0 with an emptysymbol_table).The FATAL → exit 0 half could not be reproduced on
main:src/index.tsalready exits 1 after printing FATAL, and the Neo4j case exits 1 through the same catch. A Bun 1.3.14 spike shows a whole-envelopestructuredClonecan abort the process outright (rc 133, no exception) rather than throw, so the 1.3.0rc=0afterFATAL TypeErroris unexplained. #188 removes that clone (per-module now), which removes the trigger. If a FATAL ever again exits 0, reopen with the exact stderr andrc.
Problem
cantsexits 0 when it fails. Two cases, both measured on 1.3.0:So the analyzer returns success after printing
FATAL, and returns success for an input path that does not exist — emitting a schema-valid payload describing an empty application, whoseidis derived from the last path segment of a directory that was never read.Why it matters
Every consumer runs this as a subprocess and the exit code is the only cheap health signal. A wrapper written the obvious way —
subprocess.run(..., check=True)— treats both cases as a successful run. The nonexistent-path case is worse than the crash, because it hands back a well-formed payload: an agent asking "what does this project contain?" is told, in schema-conformant JSON, that the answer is nothing.The
FATALcase is at least distinguishable by the absent output directory, and the empty-input case bysymbol_table == {}— but both require the consumer to know to look, and neither is what an exit code is for.Expected
-ipath is an error: non-zero exit, noanalysis.jsonwritten.FATALexits non-zero.An empty
symbol_tableshould mean "this project has no analysable sources", which is a real and different answer from "the input did not exist".Environment
codeanalyzer-typescript1.3.0 (PyPI wheel, bundled Bun binary), macOS 15 arm64.Related: the crash in the second case is #180. This issue is about the exit code and the payload, which are independent of what went wrong.