fix: prevent ValueError when accessing CliRunner.stderr - #746
Open
sentry[bot] wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
click.testing.CliRunnerclass defaults tomix_stderr=True, which means standard error is merged into standard output. Whenmix_stderrisTrue, thestderr_bytesattribute of theResultobject remainsNone.Attempting to access
result.stderrwhenresult.stderr_bytesisNoneraises aValueError: stderr not separately captured.This fix updates all instantiations of
CliRunner()in the test suite toCliRunner(mix_stderr=False). This ensures that standard error is always captured separately, preventing theValueErrorwhenresult.stderris accessed.Fixes CLI-FR