Skip to content

fix: handle unavailable manual execution runtimes (#1251) - #1333

Closed
raphael-goetz wants to merge 1 commit into
mainfrom
fix/1251-handle-gateway-unavailable
Closed

raphael-goetz wants to merge 1 commit into
mainfrom
fix/1251-handle-gateway-unavailable

Conversation

@raphael-goetz

Copy link
Copy Markdown
Member

What

Translate exhausted gateway UNAVAILABLE responses during manual execution pushes into a typed GraphQL mutation error instead of allowing the gRPC exception to escape.

Why

Closes #1251.

How

  • rescue GRPC::Unavailable at the manual execution service boundary
  • return the new RUNTIME_UNAVAILABLE error code
  • document the generated GraphQL enum value and cover the failure path with a service spec

Testing

  • bin/rails db:prepare
  • bundle exec rake graphql:compile_docs
  • bundle exec rubocop --autocorrect
  • bundle exec rubocop
  • bundle exec rubocop -A
  • bundle exec rspec (2,029 examples, 0 failures)

@github-actions

Copy link
Copy Markdown

GitLab Pipeline Action

General information

Link to pipeline: https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/2998639372

Status: Passed
Duration: 7 minutes

Job summaries

rspec: [cloud]

Coverage report available at https://code0-tech.gitlab.io/-/development/sagittarius/-/jobs/17535352191/artifacts/tmp/coverage/index.html
Test summary available at https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/2998639372/test_report
Finished in 30.08 seconds (files took 9.18 seconds to load)
2029 examples, 0 failures
Line Coverage: 93.48% (7241 / 7746)
[TEST PROF INFO] Time spent in factories: 00:14.829 (41.39% of total time)

rspec: [ee]

Coverage report available at https://code0-tech.gitlab.io/-/development/sagittarius/-/jobs/17535352190/artifacts/tmp/coverage/index.html
Test summary available at https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/2998639372/test_report
Finished in 45.93 seconds (files took 11.97 seconds to load)
1886 examples, 0 failures
Line Coverage: 93.62% (6896 / 7366)
[TEST PROF INFO] Time spent in factories: 00:24.845 (46.93% of total time)

rspec: [ce]

Coverage report available at https://code0-tech.gitlab.io/-/development/sagittarius/-/jobs/17535352189/artifacts/tmp/coverage/index.html
Test summary available at https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/2998639372/test_report
Finished in 51.79 seconds (files took 12.29 seconds to load)
1820 examples, 0 failures
Line Coverage: 93.2% (6658 / 7144)
[TEST PROF INFO] Time spent in factories: 00:28.335 (47.66% of total time)

docs:preview

Documentation preview available at https://code0-tech.gitlab.io/-/development/telescopium/-/jobs/17535466197/artifacts/out/index.html

rubocop

1100 files inspected, no offenses detected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handle UNAVAILABLE error from gateway

1 participant