admission: validate spec.hibernatePolicy#4
Merged
Conversation
CMGS
force-pushed
the
feat/validate-hibernate-policy
branch
2 times, most recently
from
July 24, 2026 15:01
3806a7a to
e3d8650
Compare
Every other spec enum gets an IsValid check in the CocoonSet validator; hibernatePolicy was missing when cocoon-common introduced it. Rejects unknown values with the same message shape as snapshotPolicy. cocoon-common is pinned to the spec.hibernatePolicy merge commit; the newer commonhttpx drops the unused cert/key params from HTTPSServerSpec, adapted in main.
CMGS
force-pushed
the
feat/validate-hibernate-policy
branch
from
July 24, 2026 15:22
e3d8650 to
1632c72
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
spec.hibernatePolicyvalues viaHibernatePolicy.IsValid, same message shape as thesnapshotPolicycheck — every other spec enum already gets this defense-in-depth next to the CRD enum validation.HTTPSServerSpec;main.goadapted (it passed"", ""before — behavior unchanged).Tests
New
rejects bad hibernate policycase in the validator table;go test ./...green, dual-GOOS lint clean.