review: batch-end quality round#3
Merged
Merged
Conversation
Drop the Handler const-group comment; the label names already state one endpoint per value with nothing left to add.
Dedup handleHealthz/handleReadyz into a shared writeOK helper; both wrote a 200 status plus a literal body.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Batch-end quality round: style walkthrough, comment budget, and simplify lenses.
Changed
admission/server.go:handleHealthzandhandleReadyzshared their entire body; both now call a singlewriteOKhelper.metrics/metrics.go: dropped a const-group label comment that restated the constant names.loc-justify
All four lenses (dead/vestigial, duplication, over-abstraction and hand-rolled stdlib, unreachable defense and over-design) ran over the full 783 production lines and produced no cut candidates. Nothing was manufactured to show a number.
Gates
GOWORK=off make lint(GOOS=linux and darwin): 0 issuesGOWORK=off go test -race -count=1 ./...: all packages passgolangci-lint fmt --diff ./...: cleango.mod/go.sumunmodifiedNet: -2 prod, 0 test.