Repository navigation
Restore dynamic Cython modules from shared extension paths - #622
Open
Aschenbath wants to merge 1 commit into
Open
Aschenbath wants to merge 1 commit into
Aschenbath wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cython functions and classes produced by
pyximportor IPython%%cythoncan be pickled by module name but fail to load in a fresh worker because the compiled module is outside its import path.Add the opt-in
assume_shared_dynamic_cython_module_folderkeyword toPickler,dump, anddumps. When enabled, named objects from dynamically compiled extensions can be restored from the same absolute extension path on each worker. Normal importable extensions and modules registered for pickling by value retain their existing behavior.Restore shared extensions through standard import initialization and module locking. Repeated loads retain module identity; conflicting paths fail without replacing the loaded module. The exact-name finder is removed after both successful and failed imports. Document compatibility requirements and add real
pyximport/%%cythontests, with Cython as a development dependency.Fixes #502.
Validation
tests/cloudpickle_ipykernel_test.py, also reproduced on the base revision; that file is unchanged here.python -Ipassed real-extension round trips through all three public APIs, including function/class/instance identity.masterregistered the workflows, but GitHub currently reports zero runs/check runs/statuses for this commit; remote CI has not passed.Scope and contribution disclosure
Compiled files must exist at the same absolute paths with compatible Python, ABI, platform, and native dependencies. This does not transfer or rebuild native code, support local Cython closures, or snapshot modified native module globals. Real PyPy was not run; the Python pickler branch was exercised on CPython, which does not establish PyPy/cpyext compatibility.
This implementation, tests, and PR text were prepared using OpenAI Codex. Review was performed by a separate Codex agent; no human review is claimed.