[wrangler] Add Codex Micro daemon - #14846
Conversation
|
There was a problem hiding this comment.
I'm Bonk, and I've done a quick review of your PR.
Adds a hidden wrangler --secret --{install,uninstall,run}-codex-daemon flow that installs a launchd/systemd service to watch a Codex Micro HID device and run mapped Wrangler commands.
I understand this is a demo branch not intended to merge, so most of this is informational. One concrete correctness bug and a couple of smaller notes below.
Ranked:
- (med) AG05 becomes a dead key if it is present in the keymap but resolves to no args (empty/whitespace value or a parse error).
#ag05StopsAllis decided from the raw keymap, butapplyKeymapcan delete the AG05 command, leaving AG05 doing nothing (neither stop-all nor a command). - (low)
#confirmDeployshares one confirmation window and consumes it even when the deploy command is already running (the confirm check runs before the already-active check), so an armed confirmation can be silently eaten by a press that only logs "already running". - (low)
findCodexMicrore-filters onproductId/pathafterdevicesAsync(vendorId, productId)already filtered on those — harmless but redundant.
|
Review submitted successfully to PR #14846. I reviewed the Codex Micro daemon changes and posted a batch review with one medium and two low-severity findings:
The rest (spawn without shell, XML/systemd value escaping, atomic writes, secret-flag gating, native-dep allowlist entries) looked sound for a demo branch. |
@cloudflare/autoconfig
@cloudflare/config
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
NOT TO BE MERGED. JUST NEED A CI BUILD AND
wrangler@<version>LINK FOR A SMALL DEMO