Repository navigation
fix: keep the GC insertion marker until the manifest is written - #162
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
R2Registry.putManifestreturnedthis.putManifestInner(...)withoutawaitinside atry/finally. Thefinallyblock, which callsgc.cleanInsertion, ran right away instead of after the manifest was written. A garbage collection that started during the push saw no insertion marker and deleted the layers of the manifest being pushed, which left a manifest pointing at missing blobs.This change awaits
putManifestInner, so the insertion marker stays in place until the manifest objects are written. This matchesGarbageCollector.collect, which already usesreturn awaitfor the same pattern.Testing
garbage collector > keeps the insertion marker until the manifest is written. The test wraps the R2 bucket so that anunreferencedgarbage collection runs right before the manifest is written, then checks that the layers still exist and that the GC refused to run.expected +0 to deeply equal 2(both layers deleted).pnpm testpasses (65 tests), andpnpm run typecheck,pnpm run lint,pnpm run format:checkandpnpm run generate-types:checkare clean.Fixes #161