ZTC-3215: Add pause syscall to seccomp SERVICE_BASICS allowlist - #241
Open
OmegaJak wants to merge 2 commits into
Open
ZTC-3215: Add pause syscall to seccomp SERVICE_BASICS allowlist#241OmegaJak wants to merge 2 commits into
OmegaJak wants to merge 2 commits into
Conversation
nmldiegues
approved these changes
Jul 31, 2026
fisherdarling
approved these changes
Jul 31, 2026
Contributor
Author
|
It seems glibc pause is implemented using ppoll instead on aarch64: https://codebrowser.dev/glibc/glibc/sysdeps/unix/sysv/linux/pause.c.html#31 So I've added the relevant #[cfg] to allow ppoll with those specific arguments on aarch64 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
std::process::exit()has a safeguard on linux againstlibc::exitthread unsafety which will pause a thread if it tried to exit simultaneously with another thread. This pause uses the pause syscall.If this race condition is triggered with the default seccomp configuration, the process will be killed by seccomp. This has been observed in a production environment.
This PR adds the
pausesyscall to the default seccomp allowlist to avoid this issue.I don't think this poses any meaningful additional security risk by allowing potential malicious code to invoke it - at most, it can suspend a thread indefinitely, which I believe could already be accomplished with the
futexsyscall, which is already in theRUST_BASICSallowlist.