Reduce CI usage#8256
Conversation
macOS runners are slow and for PyPy users should switch to JSON-RPC bindings. We are only running legacy Python tests to test the Rust code behaivor and CFFI, but not the Python bindings, so testing one implementation is enough.
link2xt
force-pushed
the
link2xt/reduce-ci-usage
branch
2 times, most recently
from
8ec4151 to
19d3485
Compare
|
This means we won't test the CFFI on Macos anymore? Isn't this a problem because Deltachat-iOS uses the CFFI? Or is it fine because we don't change it, so we assume that it will keep working? |
I doubt that it is likely that CFFI suddenly fails on an old method. I don't think its likely that our thin wrapper crate contains something in the older methods that suddenly breaks in newer operating system versions and in newly added methods we would see it during testing if something doesn't work only on macOS. As long as deltachat's C interface keeps not doing platform specific stuff (like not using Objective-C types), I'd say it's fine to just test it on Linux. An alternative could be to only enable macOS CFFI testing on release tags, that would be enough to catch such an unlikely issue while still saving CI time. |
|
yip, android, iOS and ubuntu-touch use cffi. so it makes some sense to test that somewhere, also to see if "it os only my machine" as recently on android. it is not critical, but very handy to see failures soon. we had them in the past a lot on iOS, but not recently iirc. however, that test does not need to include "legacy pyton" - is apple tested somewhere else in CI? otherwise, before putting resouces into doing that, maybe just leave things as is up to when legacy phyton is removed alltogether |
4 participants
No description provided.