Refactor commit message to unit test#94
Merged
Merged
Conversation
Andarist
previously approved these changes
Jun 11, 2026
| - name: Build | ||
| run: pnpm build | ||
|
|
||
| - name: Unit tests |
Member
There was a problem hiding this comment.
We could push this to another job so it would run on forks. at the moment, we rely on merge queue rejecting broken integration tests because those require secrets.
It would complicate the setup though so perhaps it's not worth it
Member
Author
There was a problem hiding this comment.
Ah that makes sense. I'd like to push more tests as unit tests so forks can run it. I think I can follow up later
Andarist
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have some integration tests to verify that the commit message works properly. I think this is overkill and slows down the CI. I refactored it as a unit test instead.
It's not completely perfect here, ideally we'd spy on the octokit call to verify that the commit message is properly passed. But right now, I'm planning some API changes that will change that part so I didn't do it for now.