-
Notifications
You must be signed in to change notification settings - Fork 102
CFE-4708: Added support for a path-augment to specify files to ship beyond the extension-matching #3204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SimonThalvorsen
wants to merge
4
commits into
cfengine:master
Choose a base branch
from
SimonThalvorsen:CFE-4708
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+63
−0
Open
CFE-4708: Added support for a path-augment to specify files to ship beyond the extension-matching #3204
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
9d146d0
Added support for a path-augment to specify files to ship beyond just…
SimonThalvorsen 8230537
Gate input_paths_extra behind validated_updates_ready
nickanderson 62492b9
another attmpt
nickanderson df76082
Removed `input_paths_extra_safe` and added some comments
SimonThalvorsen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure WHERE exactly is the best place, but it's worth knowing that the implementation below will not work for additional augments. If someone populates the augments key with extra json files that set the same variable ... those extra files would be lost on the re-definition of those extra paths below.