Repository navigation
cf-check: Fix segfault on missing state directory - #6359
Merged
Merged
Conversation
|
Thanks for submitting a PR! Maybe @larsewi can review this? |
larsewi
reviewed
Sep 22, 2026
larsewi
left a comment
larsewi
left a comment
Contributor
There was a problem hiding this comment.
This is good. However, I still think argv_to_lmdb_files should return NULL on failure, so that the call sites can handle it.
The memory leak is preexisting. But, feel free to fix it too, preferably in a separate commit.
Thanks again!
Contributor
|
@btriller this looks good. Can you please squash the three commits? |
Contributor
|
@cf-bottom Jenkins please :) |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/14981/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-14981/ |
btriller
force-pushed
the
cf-check-segfault
branch
from
November 5, 2026 06:48
ecbbc24 to
9495bd4
Compare
larsewi
approved these changes
Nov 5, 2026
larsewi
added
the
cherry-pick?
Contributor
|
Backport to 3.24.x: #6475 |
Contributor
|
Backport to 3.27.x: #6474 |
This was referenced Nov 5, 2026
larsewi
removed
the
cherry-pick?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.