fix: align Uniswap V4 hook guidance and security checks - #6
Merged
ccashwell merged 2 commits intoAug 4, 2026
Merged
Conversation
* fix: align Uniswap v4 hook guidance with current APIs * fix: address Uniswap v4 review findings * fix: keep hook guidance on pinned dependencies * fix: remove mutable template assumptions * fix: clarify exact-output fee boundary * fix: cover missing V4 hook security checks * fix: remove redundant skill references
Resolves conflicts in skills/uniswap-v4-hooks/SKILL.md between this branch's prose rewrite and PR ccashwell#5's example-hook bug fixes. The rewrite already removed the buggy AllowlistHook/SwapFeeHook/ConstantSumHook examples and states PR ccashwell#5's lessons as guidance (sender vs end user, unspecified-currency deltas, delta settlement), so the rewrite is kept and the two additive details from PR ccashwell#5 are folded into "Return Deltas and Custom Accounting": the four-quadrant specified/unspecified table and the take()-or-CurrencyNotSettled() behavior of returned credits. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IUnlockCallbackauthorization, returned liquidity deltas, full state and custody domains, external price sources, lifecycle paths, and exit liveness.