Skip to content

Fix misleading filename docstring (empty path returns Just "", not Nothing) #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hellerve merged 1 commit into from
Jun 29, 2026
Merged

Fix misleading filename docstring (empty path returns Just "", not Nothing) #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion path.carp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ As such, it is the inverse to [split](#split).")

(doc filename "gets the filename of the path `p` as a `(Maybe String)`.

It will return `Nothing` if an empty string is passed.")
For an empty path, the result is `Just` of an empty string, never `Nothing`.")
(defn filename [p] (Array.last &(split p)))
(doc basename "gets the basename of the path `p`.")
(defn basename [p]
Expand Down
Loading