Repository navigation
docs: say that Solid Objects Pro ships for Node.js - #69
Merged
Merged
Conversation
The agent guide and the fit guide said that the Node build of Solid Objects Pro was in development. @solidobjects/pro ships today from the private registry at solidobjects.pro, beside the Rails gem, so an agent that read the old text ruled out Pro for a Node.js hot key.
|
Docs7 for cardmagic/solid-objects-js
Commit |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
docs/agents.mdanddocs/fit.mdsaid that the Node build of Solid Objects Pro was in development. That is out of date. https://solidobjects.pro lists the Node.js and Rails Pro packages as shipping.@solidobjects/proinstalls from the private registry with npm or pnpm. An agent that read the old text ruled out Pro for a Node.js hot key.What changed
docs/agents.md, simpler-tool table: "A counter column, a cache, or Solid Objects Pro, which ships for Node.js and Rails". This matches the Ruby agent guide.docs/agents.md, package identity:@solidobjects/prois "a separate paid package from the private registry at https://solidobjects.pro".docs/fit.md: Pro "ships for Node.js as@solidobjects/proand for the Rails gem".No Pro version number appears in the docs.
Validation
pnpm run format:check,pnpm run check(includes the documentation check),pnpm test(589 passed, 32 database skips),pnpm run build,pnpm run pack:check, andpnpm run test:package.