Support Windows runtimes and symbolic source refs - #56
Open
sj26 wants to merge 3 commits into
Open
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-01a093cf-d95d-729c-8ed0-137c3d9f23ec Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-01a093cf-d95d-729c-8ed0-137c3d9f23ec Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-01a093cf-d95d-729c-8ed0-137c3d9f23ec Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Testing experimental Windows jobs with
source-refcurrently fails because the plugin only builds Linux and macOS runtimes. Testing a moving runtime branch also requires manually updating a full commit SHA.What
Build Windows amd64 alongside Linux and macOS, and accept a commit, branch, or tag for
source-ref. Resolve symbolic refs once and build every executable from that same commit. Annotated tags use their peeled commit; ambiguous branch/tag names fail rather than silently choosing one.For a build with server-selected workflow context, the test configuration can omit workflow paths and runner overrides:
The importer still runs on Linux amd64 or Darwin arm64. Experimental Windows jobs require compatible source (buildkite/buildkite-gha#488) and available runner mapping/queues. Stable release selection is unchanged.