Repository navigation
Merge PTAAA-881-remove-ai-extension-healing-v8 - #330
Merged
bsautomation merged 5 commits intoNov 2, 2026
Merged
Conversation
…pendency v8 port of #315, which landed the same removal on main (wdio v9). The security fix has to ship in every supported major, and v8 carries the identical vulnerable path pinned to @browserstack/ai-sdk-node 1.5.17. The client-side healing path downloaded the AI browser extension via BrowserstackHealing.init() and loaded it into the local browser, either through goog:chromeOptions.extensions or browser.installAddOn(). That extension ships a window.postMessage handler that forwards a page-controlled endpoint and bearer to a privileged background fetch, giving any visited page an SSRF primitive against the machine running the test. The path is deprecated and only ever ran off BrowserStack infra, so it is removed rather than hardened. Removes AiHandler and its two entry points, the healing branch of the funnel instrumentation, the capability helpers and constants left without callers, the self-heal performance events, and the @browserstack/ai-sdk-node dependency. Self-healing on BrowserStack infra is unaffected: it is driven by the browserstack.selfHeal capability, resolved hub-side, and never went through this code. BrowserstackConfig.selfHeal is deliberately kept, and an off-infra run that sets it now gets a one-time warning instead of silently losing healing. Typecheck 12 -> 9 errors (3 removed, 0 added; the rest pre-existing). Tests 738 -> 728 passing with 0 failures either side; the 10-test drop is the deleted healing suites. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
sendEvent was only read by the healing instrumentation helpers removed with AiHandler, so it is dead once they go — the same no-unused-vars failure this file hit on main. The new selfHeal warning gated on !shouldAddServiceVersion(...), which also returns false for a chromedriver service with observability left on. A genuine BrowserStack session could therefore be told it was not running on BrowserStack infrastructure. Gate on isBrowserstackInfra() instead, which is the condition the message actually describes. shouldAddServiceVersion stays for its four other callers. Typecheck unchanged at 9 pre-existing errors; tests unchanged at 728 passing / 0 failures. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
…e.ts Its only call site was the healing block removed in this PR; the call went and the import stayed. Same no-unused-vars shape as the sendEvent map. Swept the named imports of every file this PR touches — this was the only one left dangling. Typecheck unchanged at 9 pre-existing errors; tests unchanged at 728 passing / 0 failures. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Picks up the root-level mocha hook fix (#309). One conflict in service.ts: its new _setCliSuiteFile(specs?.[0]) call sits directly above the healing block this branch removes, so the delete read as covering both. Kept the mocha call, dropped only the healing block. Tests 731 passing / 0 failures, including all 12 of the new mocha-hook tests; typecheck unchanged at 9 pre-existing errors. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
bsautomation
requested review from
pranay-v29 and
yashdsaraf
and removed request for
a team
November 2, 2026 14:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge into sdk_v8_pre_prod :by automationbs
v8)