Skip to content

CHANGELOG.md and codecov.yml slipped into the release#114

Merged
BenMorel merged 2 commits into
brick:mainfrom
szepeviktor:patch-1
Jun 27, 2026
Merged

CHANGELOG.md and codecov.yml slipped into the release#114
BenMorel merged 2 commits into
brick:mainfrom
szepeviktor:patch-1

Conversation

@szepeviktor

Copy link
Copy Markdown
Contributor

Fix both.

@codecov

codecov Bot commented Jun 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.04%. Comparing base (8294432) to head (6ecfe26).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #114   +/-   ##
=========================================
  Coverage     99.04%   99.04%           
  Complexity      761      761           
=========================================
  Files            20       20           
  Lines          1882     1882           
=========================================
  Hits           1864     1864           
  Misses           18       18           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@BenMorel

Copy link
Copy Markdown
Member

Thank you for your PR, @szepeviktor! I think CHANGELOG.md should stay, though.

Removed CHANGELOG.md from export-ignore list in .gitattributes.
@szepeviktor

Copy link
Copy Markdown
Contributor Author

Your wish is my command.

My 2 cents: no one will go into vendor/ and read a file.

@BenMorel BenMorel merged commit fcd3e93 into brick:main Jun 27, 2026
22 checks passed
@BenMorel

Copy link
Copy Markdown
Member

Thank you! Even though not many people may read them, I think README / CHANGELOG / LICENSE are documentation that should ship with the release.

@szepeviktor szepeviktor deleted the patch-1 branch June 27, 2026 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants