Mark encryption writer registration stages implemented

[bootjp]

Summary

• mark writer registration and runtime re-registration encryption stages implemented
• update the data-at-rest encryption milestone table with shipped Stage 7 docs
• update the conf-change registration reference to the implemented design doc

Design docs

• docs/design/2026_05_26_implemented_7a_process_start_registration.md
• docs/design/2026_05_26_implemented_7a2_storage_layer_registration_enforcement.md
• docs/design/2026_05_28_implemented_7b_runtime_reregistration.md
• docs/design/2026_05_28_implemented_7b_prime_runtime_reregistration_rotation.md
• docs/design/2026_05_29_implemented_7c_confchange_time_registration.md

Validation

• go test ./internal/encryption ./adapter -run 'Test.*Registration|Test.*Writer|Test.*LocalEpoch|Test.*EncryptionAdmin' -count=1
• golangci-lint --config=.golangci.yaml run ./internal/encryption ./adapter --timeout=5m
• git verify-commit HEAD

Author: bootjp

[coderabbitai]

Warning

Review limit reached

@bootjp, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 36 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f798a4e4-996c-4116-8b76-c2b31bd60410

📥 Commits

Reviewing files that changed from the base of the PR and between 264599a and 51d2a98.

📒 Files selected for processing (8)

• docs/design/2026_04_29_partial_data_at_rest_encryption.md
• docs/design/2026_05_26_implemented_7a2_storage_layer_registration_enforcement.md
• docs/design/2026_05_26_implemented_7a_process_start_registration.md
• docs/design/2026_05_28_implemented_7b_prime_runtime_reregistration_rotation.md
• docs/design/2026_05_28_implemented_7b_runtime_reregistration.md
• docs/design/2026_05_29_implemented_7c_confchange_time_registration.md
• internal/raftadmin/interceptor.go
• main_encryption_confchange.go

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[gemini-code-assist]

Code Review

This pull request updates several design documents related to Stage 7 of the data-at-rest encryption for elastickv (writer registry and deterministic nonce) to reflect their status as "implemented" rather than "proposed". It adds implementation audit sections to these documents detailing the specific code locations and tests where the features are implemented, and updates references and comments accordingly. There are no review comments, so I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[bootjp]

@codex review

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c07a4d706d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[bootjp]

Addressed the current review feedback in e6554b12:

• Updated the remaining Stage 7c design-doc reference to the implemented file.
• Corrected the Stage 7b' audit symbol to internal/encryption.WithLocalEpoch.
• Narrowed the parent encryption design doc so Stage 7 is marked partial, with the §5.5 WriterRegistryForCaller projection still explicitly open.
• Merged current main.

Validation:

• go test ./adapter ./internal/raftadmin -run 'TestEncryptionAdmin_(GetSidecarState|ResyncSidecar)|Test.*Membership|Test.*Interceptor' -count=1 -timeout=240s
• go test . ./adapter ./internal/raftadmin -run '^$' -count=0 -timeout=180s
• git diff --cached --check

@codex review

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e6554b12d5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[bootjp]

Addressed the latest review threads in f016bbb.

Validation:

• git diff --check
• go test ./internal/encryption -run 'TestApplyRotateDEK' -count=1 -timeout=300s
• go test ./adapter -run 'Test.*RotateDEK|Test.*SidecarState|Test.*ResyncSidecar|Test.*WriterRegistry' -count=1 -timeout=300s

@codex review

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. Hooray!

Reviewed commit: f016bbbcb0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[bootjp]

Merged current main into 51d2a98 and resolved the parent encryption design-doc conflict while preserving Stage 7 partial status and Stage 8 shipped status.

Validation:

• git diff --check
• go test ./internal/encryption -run 'TestApplyRotateDEK' -count=1 -timeout=300s
• go test ./adapter -run 'Test.*RotateDEK|Test.*SidecarState|Test.*ResyncSidecar|Test.*WriterRegistry' -count=1 -timeout=300s
• go test . ./internal/encryption ./adapter -run '^$' -count=0 -timeout=180s

@codex review

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: 51d2a98884

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".