Mark raft learner support implemented by bootjp · Pull Request #1002 · bootjp/elastickv

bootjp · 2026-07-07T05:59:46Z

Summary

promote the raft learner design doc to implemented status
update in-tree references from proposed to implemented naming
keep the scaling roadmap aligned with the implemented learner primitive

Design doc

docs/design/2026_04_26_implemented_raft_learner.md

Validation

go test ./internal/raftengine/etcd ./cmd/raftadmin -run 'Test.*Learner|Test.*AddLearner|Test.*PromoteLearner|Test.*raftJoinAsLearner|Test.*JoinAsLearner' -count=1
golangci-lint --config=.golangci.yaml run ./internal/raftengine/etcd ./cmd/raftadmin --timeout=5m
git verify-commit HEAD

Author: bootjp

Summary by CodeRabbit

Documentation
- 学習者（learner）機能の設計資料を「Implemented」に更新し、対応済みの範囲と未完了項目を整理しました。
- learner に対する LinearizableRead は ErrNotLeader を返す想定へ統一し、関連資料の記述を合わせました。
- 起動オプション、管理操作、運用ガイド、設計コメントの参照先を最新の仕様に更新しました。

coderabbitai · 2026-07-07T05:59:54Z

Warning

Review limit reached

@bootjp, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 3 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 00d9fc2d-836f-4df7-945c-a40b8a84ddd8

📥 Commits

Reviewing files that changed from the base of the PR and between 4fb6368 and 47a1748.

📒 Files selected for processing (6)

docs/design/2026_04_26_implemented_raft_learner.md
docs/design/2026_06_23_proposed_scaling_roadmap.md
internal/raftengine/etcd/engine.go
internal/raftengine/etcd/peers.go
internal/raftengine/factory.go
main.go

📝 Walkthrough

Walkthrough

raft learner 設計ドキュメントのステータスが「Proposed」から「Implemented」に更新され、learner 上の LinearizableRead が ErrNotLeader を返す挙動として記述変更された。関連するコード・ドキュメント内のコメント参照が、旧設計文書ファイル名から新しい実装版ファイル名へ一括で更新された。

Changes

Raft Learner 設計文書更新と参照修正

Layer / File(s)	Summary
設計文書ステータスとLinearizableRead挙動の更新 `docs/design/2026_04_26_implemented_raft_learner.md`	文書ステータスが Implemented に更新され、learner 上の `LinearizableRead` が `ErrNotLeader` を返す方針へ記述変更、マイルストーン2・3の達成/未達事項が明確化された。
関連ドキュメントの参照更新 `docs/design/2026_06_23_proposed_scaling_roadmap.md`, `docs/raft_learner_operations.md`	スケーリングロードマップと learner 運用ドキュメントの参照リンクが実装版設計ドキュメントへ更新された。
コード内コメントの参照パス更新 `internal/raftengine/engine.go`, `internal/raftengine/etcd/engine.go`, `internal/raftengine/etcd/peers.go`, `internal/raftengine/etcd/wal_store.go`, `internal/raftengine/etcd/learner_test.go`, `internal/raftengine/factory.go`, `main.go`	各ファイルのコメントおよびヘルプ文字列にある設計ドキュメント参照パスが proposed 版から implemented 版へ置き換えられた。

Estimated code review effort: 1 (Trivial) | ~5 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	Raft learner対応を実装済みとして扱う変更内容を端的に表しており、主要な差分と一致しています。
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

gemini-code-assist

Code Review

This pull request updates the status of the Raft Learner design document from proposed to implemented, renaming its file references across the codebase. The review feedback correctly identifies a logical contradiction in the scaling roadmap document where the text still references the old filename as if it hasn't been updated, and suggests a clear correction.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

bootjp · 2026-07-07T08:54:05Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cbb6b8dd9f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

bootjp · 2026-07-08T00:38:20Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cbb6b8dd9f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

bootjp · 2026-07-08T19:56:10Z

Addressed the latest review threads and pushed d3c36b4.

Validation:

git diff --check
go test ./internal/raftengine/etcd ./internal/raftengine -run 'Test.*Learner|Test.*ConfState|Test.*Peer|Test.*WAL|Test.*JoinAsLearner|Test.*PromoteLearner|Test.*LinearizableRead' -count=1 -timeout=300s
go test . ./internal/raftengine/etcd ./internal/raftadmin ./cmd/raftadmin -run '^$' -count=0 -timeout=180s

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d3c36b4f43

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

bootjp · 2026-07-08T20:11:01Z

Addressed the latest learner API snippet review thread in 2edb475 and merged current main.

Validation:

git diff --cached --check
go test ./internal/raftengine/etcd ./internal/raftengine -run 'Test.*Learner|Test.*ConfState|Test.*Peer|Test.*WAL|Test.*JoinAsLearner|Test.*PromoteLearner|Test.*LinearizableRead' -count=1 -timeout=300s
go test . ./internal/raftengine/etcd ./internal/raftadmin ./cmd/raftadmin -run '^$' -count=0 -timeout=180s

@codex review

chatgpt-codex-connector · 2026-07-08T20:14:43Z

Codex Review: Didn't find any major issues. 🚀

Reviewed commit: 2edb47590d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

…upport # Conflicts: # main.go

bootjp · 2026-07-10T14:27:06Z

対応しました。

origin/main を merge し、main.go の conflict を解消しました。
learner flag の implemented design doc 参照を保持し、current main の TSO flags も落とさず統合しました。

検証:

git diff --check
go test ./internal/raftengine/etcd ./internal/raftengine -run 'Test.*Learner|Test.*ConfState|Test.*Peer|Test.*WAL|Test.*JoinAsLearner|Test.*PromoteLearner|Test.*LinearizableRead' -count=1 -timeout=300s\n- go test . ./internal/raftengine/etcd ./internal/raftadmin ./cmd/raftadmin -run '^$' -count=0 -timeout=180s\n\n@codex review

chatgpt-codex-connector · 2026-07-10T14:30:14Z

Codex Review: Didn't find any major issues. Hooray!

Reviewed commit: 47a1748fe3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

docs: mark raft learner support implemented

66ada97

gemini-code-assist Bot reviewed Jul 7, 2026

View reviewed changes

Comment thread docs/design/2026_06_23_proposed_scaling_roadmap.md Outdated

Clarify raft learner roadmap status

cbb6b8d

chatgpt-codex-connector Bot reviewed Jul 7, 2026

View reviewed changes

Comment thread docs/design/2026_04_26_implemented_raft_learner.md Outdated

bootjp marked this pull request as ready for review July 8, 2026 00:38

chatgpt-codex-connector Bot reviewed Jul 8, 2026

View reviewed changes

Comment thread docs/design/2026_04_26_implemented_raft_learner.md Outdated

bootjp added 2 commits July 9, 2026 04:51

Merge main into raft learner docs

4fb6368

Clarify raft learner roadmap status

d3c36b4

chatgpt-codex-connector Bot reviewed Jul 8, 2026

View reviewed changes

Comment thread docs/design/2026_04_26_implemented_raft_learner.md

Merge main into raft learner support

2edb475

Merge remote-tracking branch 'origin/main' into design/raft-learner-s…

47a1748

…upport # Conflicts: # main.go

bootjp merged commit 66eb385 into main Jul 10, 2026
9 checks passed

bootjp deleted the design/raft-learner-support branch July 10, 2026 14:54

Conversation

bootjp commented Jul 7, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Design doc

Validation

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jul 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Walkthrough

Changes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

bootjp commented Jul 7, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

bootjp commented Jul 8, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

bootjp commented Jul 8, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

bootjp commented Jul 8, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jul 8, 2026

Uh oh!

bootjp commented Jul 10, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jul 10, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

bootjp commented Jul 7, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 7, 2026 •

edited

Loading